Hi John, On Thu, Jun 19, 2025 at 02:10:27PM +0100, John Garry wrote: > On 19/06/2025 12:05, Alejandro Colomar wrote: > >> @@ -74,6 +74,9 @@ struct statx { > >> \& > >> /* File offset alignment for direct I/O reads */ > >> __u32 stx_dio_read_offset_align; > >> +\& > >> + /* Direct I/O atomic write max opt limit */ > >> + __u32 stx_atomic_write_unit_max_opt; > > Please align the member with the one above. > > stx_dio_read_offset_align is actually misaligned (to the member above it): > > /* Direct I/O atomic write limits */ > __u32 stx_atomic_write_unit_min; > __u32 stx_atomic_write_unit_max; > __u32 stx_atomic_write_segments_max; > > /* File offset alignment for direct I/O reads */ > __u32 stx_dio_read_offset_align; > > I'll just fix that separately. Ahh, thanks! I couldn't see that from the context. Makes sense. :) Cheers, Alex -- <https://www.alejandro-colomar.es/>
Attachment:
signature.asc
Description: PGP signature