Re: [PATCH 4/7] xfs: refactor xfs_calc_atomic_write_unit_max

[John Garry <john.g.garry@xxxxxxxxxx>]

On 18/06/2025 06:08, Christoph Hellwig wrote:
> > > -	struct xfs_groups	*rgs = &mp->m_groups[XG_TYPE_RTG];
> > > +	struct xfs_groups	*g = &mp->m_groups[type];
> > > +	struct xfs_buftarg	*btp = type == XG_TYPE_RTG ?
> > > +			mp->m_rtdev_targp : mp->m_ddev_targp;
> > Could this be made a bit more readable?
> Suggestions welcome.

I thought that you did not like the ternary operator :)

Using an if-else would bloat the code, so I suppose what you have is ok.