On Tue, Jun 17, 2025 at 12:52:01PM +0200, Christoph Hellwig wrote: > All checks the checks done in bdev_validate_blocksize are already > performed in xfs_readsb and xfs_validate_sb_common. For the data device, yes. I don't obviously see anywhere else that we check the fs external log dev or rt device sector size against the block device sector size, so unless I'm just being blind it seems to me that this check in xfs_configure_buftarg() is still necessary for those devices. -Dave. -- Dave Chinner david@xxxxxxxxxxxxx
