Re: [PATCH 1/7] net: core: Convert inet_addr_is_any() to sockaddr_storage

Date Prev

Date Next

Thread Prev

Thread Next

Date Index

Thread Index

Subject: Re: [PATCH 1/7] net: core: Convert inet_addr_is_any() to sockaddr_storage

From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>

Date: Tue, 20 May 2025 21:26:42 -0400

Cc: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>, "Gustavo A . R . Silva" <gustavoars@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Sagi Grimberg <sagi@xxxxxxxxxxx>, Chaitanya Kulkarni <kch@xxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Mike Christie <michael.christie@xxxxxxxxxx>, Max Gurtovoy <mgurtovoy@xxxxxxxxxx>, Maurizio Lombardi <mlombard@xxxxxxxxxx>, Dmitry Bogdanov <d.bogdanov@xxxxxxxxx>, Mingzhe Zou <mingzhe.zou@xxxxxxxxxxxx>, Christophe Leroy <christophe.leroy@xxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxx>, "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, Andrew Lunn <andrew+netdev@xxxxxxx>, Stanislav Fomichev <sdf@xxxxxxxxxxx>, Cosmin Ratiu <cratiu@xxxxxxxxxx>, Lei Yang <leiyang@xxxxxxxxxx>, Ido Schimmel <idosch@xxxxxxxxxx>, Samuel Mendoza-Jonas <sam@xxxxxxxxxxxxxxxx>, Paul Fertser <fercerpav@xxxxxxxxx>, Alexander Aring <alex.aring@xxxxxxxxx>, Stefan Schmidt <stefan@xxxxxxxxxxxxxxxxxx>, Miquel Raynal <miquel.raynal@xxxxxxxxxxx>, Hayes Wang <hayeswang@xxxxxxxxxxx>, Douglas Anderson <dianders@xxxxxxxxxxxx>, Grant Grundler <grundler@xxxxxxxxxxxx>, Jay Vosburgh <jv@xxxxxxxxxxxxx>, "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx>, Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>, Wei Liu <wei.liu@xxxxxxxxxx>, Dexuan Cui <decui@xxxxxxxxxxxxx>, Jiri Pirko <jiri@xxxxxxxxxxx>, Eric Biggers <ebiggers@xxxxxxxxxx>, Milan Broz <gmazyland@xxxxxxxxx>, Philipp Hahn <phahn-oss@xxxxxx>, Ard Biesheuvel <ardb@xxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Ahmed Zaki <ahmed.zaki@xxxxxxxxx>, Alexander Lobakin <aleksander.lobakin@xxxxxxxxx>, Xiao Liang <shaw.leon@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-wpan@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, linux-hyperv@xxxxxxxxxxxxxxx, linux-hardening@xxxxxxxxxxxxxxx

In-reply-to: <20250520223108.2672023-1-kees@kernel.org> (Kees Cook's message of "Tue, 20 May 2025 15:31:00 -0700")

Organization: Oracle Corporation

References: <20250520222452.work.063-kees@kernel.org> <20250520223108.2672023-1-kees@kernel.org>

Kees,

> All the callers of inet_addr_is_any() have a sockaddr_storage-backed
> sockaddr. Avoid casts and switch prototype to the actual object being
> used.

Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx> # SCSI

-- 
Martin K. Petersen