Re: [PATCH] mac802154_hwsim: define perm_extended_addr initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Ramon,

On 25/03/2025 at 13:53:12 -03, Ramon Fontes <ramonreisfontes@xxxxxxxxx> wrote:

> This establishes an initialization method for perm_extended_addr, aligning it with the approach used in mac80211_hwsim.

You are now enforcing an (almost) static value, is that the intended
behaviour? If yes I would like a better explanation of why this is
relevant and how you picked eg. 0x02 as prefix to justify the change.

In general I am not opposed, even though I kind of liked the idea of
generating random addresses, especially since hwsim is not the only one
to do that and having a simulator that behaves like regular device
drivers actually makes sense IMO.

Also, please wrap the commit log.

> Signed-off-by: Ramon Fontes <ramonreisfontes@xxxxxxxxx>

Thanks,
Miquèl





[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux