Hi Liao, On Mon, Aug 18, 2025 at 4:44 PM Liao Yuanhong <liaoyuanhong@xxxxxxxx> wrote: > > Some simple if-else logic can be simplified using the ! operator to improve > code readability. > > Signed-off-by: Liao Yuanhong <liaoyuanhong@xxxxxxxx> > --- > drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c b/drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c > index d0e299803225..164ee0fde03b 100644 > --- a/drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c > +++ b/drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c > @@ -1803,10 +1803,7 @@ static void _dpk_onoff(struct rtw89_dev *rtwdev, enum rtw89_rf_path path, bool o > > val = dpk->is_dpk_enable && !off && dpk->bp[path][kidx].path_ok; Is this line ^^^ > > - if (off) > - off_reverse = false; > - else > - off_reverse = true; > + off_reverse = !off; > > val = dpk->is_dpk_enable & off_reverse & dpk->bp[path][kidx].path_ok; The same as this line ^^^ and if so, can we just delete the second one? Also, can we also then delete the "off_reverse" variable? Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/
