On 26/08/2025 12:00, Ping-Ke Shih wrote: >>> >>> +static inline >>> +u8 rtw89_chip_get_ch_dma(struct rtw89_dev *rtwdev, u8 qsel) >>> +{ >>> + const struct rtw89_chip_info *chip = rtwdev->chip; >>> + >>> + return chip->ops->get_ch_dma(rtwdev, qsel); >>> +} >>> + >>> static inline >>> void rtw89_chip_mac_cfg_gnt(struct rtw89_dev *rtwdev, >>> const struct rtw89_mac_ax_coex_gnt *gnt_cfg) >>> >>> Also the rtw89_core_get_ch_dma() is moved to core.c, and add >>> rtw89_core_get_ch_dma_v1() for RTL8922DE. >>> >>> However, USB can use different mapping rule, so we should extend the size >>> to RTW89_HCI_TYPE_NUM. Then, >>> >>> return chip->ops->get_ch_dma[rtwdev->hci.type](rtwdev, qsel); >>> >>> If you want my patch as first patch of this patchset, I can share it as RFC. >>> >> >> Yes, that would be good. > > Finally, I decide to send a formal patch within patchset for coming WiFi 7 chip. > "[PATCH rtw-next 09/10] wifi: rtw89: abstract getting function of DMA channel" > > [1] https://lore.kernel.org/linux-wireless/20250826085339.28512-1-pkshih@xxxxxxxxxxx/T/#u > > That's great, I will prepare v3 then.