On Mon, 2025-09-08 at 21:25 +0530, Sarika Sharma wrote: > On 9/4/2025 2:56 PM, Johannes Berg wrote: > > On Fri, 2025-08-22 at 10:51 +0530, Sarika Sharma wrote: > > > Currently tx_handlers_drop statistics are handled only for slow TX > > > path and only at radio level. This also requires > > > CONFIG_MAC80211_DEBUG_COUNTERS to be enabled to account the dropped > > > packets. There is no way to check these stats for fast TX, > > > at interface level and monitor without enabling the debug configuration. > > > > > > Hence, add a new counter at the sdata level to track packets dropped > > > with reason as TX_DROP during transmission for fast path, slow path > > > and other tx management packets. Expose this via ethtool statistics, > > > to improve visibility into transmission failures at interface level > > > and aid debugging and performance monitoring. > > > > > > Place the counter in ethtool with other available tx_* stats for > > > better readability and accurate tracking. > > > > As much as I don't like ethtool for wifi, I guess you found a use where > > it's actually the right thing to use even in wifi ;-) > > > > But why not remove the old debug statistic, you have a superset now? > > I believe you're referring to removing TX_DROP_HANDLER from the > DEBUG-enabled statistics as part of cleaning up the old debug entries. > > If that's the case, I’ll go ahead and send a follow-up patch to remove it? Works for me. johannes
