On Wed, Aug 13, 2025 at 04:04:27PM -0700, Rosen Penev wrote: > On Wed, Aug 13, 2025 at 1:16 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > > > On 12/08/2025 21:23, Rosen Penev wrote: > > > The ath9k driver has various pin GPIO numbers for different chipsets > > > which are not always correct for every device. > > > > > > Add bindings to specify the correct number and if it should be > > > active-low. > > > > > > Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx> > > > --- > > > .../bindings/net/wireless/qca,ath9k.yaml | 14 ++++++++++++++ > > > 1 file changed, 14 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml > > > index d16ca8e0a25d..e701046146f2 100644 > > > --- a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml > > > +++ b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml > > > @@ -50,6 +50,17 @@ properties: > > > > > > ieee80211-freq-limit: true > > > > > > + led: > > > + type: object > > > > Each node must end with additional/unevaluatedProperties: false. See > > example schema and writing schema. > > > > That will probably lead you to missing LED common binding. > > > > > > + properties: > > > + reg: > > > + maxItems: 1 > > > + > > > + led-active-low: > > > + description: > > > + LED is enabled with ground signal. > > > > Aren't you redefining existing properties? > I don't think led-active-low is specified in any central location: True, because it is active-low which you could easily find if you opened and read the LED binding you were already referencing here. Best regards, Krzysztof
