On Thu, Jul 31, 2025 at 09:56:56PM +0200, Johannes Berg wrote:
> On Fri, 2025-07-25 at 23:22 +1000, Lachlan Hodges wrote:
> >
> > +static inline u8 *tim_push(u8 **p, u8 v)
> > +{
> > + *(*p)++ = v;
> > + return *p;
> > +}
>
> The robot complains about this, there should (normally) not be inline in
> C files.
>
> Also, looks like you don't need the return value?
>
> Anyway, it's the middle of the merge windows, so I guess it'll be a
> while before I apply things.
That's fine - I can submit a v3 once the merge window closes with these
minor fixups, no rush from our end. Plus its always good getting the
dopamine hit from seeing all green :)
lachlan
