On 29/07/2025 21:27, Sean Anderson wrote:
> There are more unsupported functions than just LOWRT_RTY. Improve on
> commit 3b66519b023b ("wifi: rtw89: phy: add dummy c2h handler to avoid
> warning message") by printing a message just once when we first
> encounter an unsupported class. This prevents messages like
>
> rtw89_8922ae 0000:81:00.0: PHY c2h class 2 not support
>
> from filling up dmesg.
>
I also get "MAC c2h class 1 func 3 not support" and "MAC c2h class
0 func 6 not support" with RTL8832CU.
The second one appears a lot in AP mode.
> Signed-off-by: Sean Anderson <sean.anderson@xxxxxxxxx>
> ---
>
> drivers/net/wireless/realtek/rtw89/phy.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw89/phy.c b/drivers/net/wireless/realtek/rtw89/phy.c
> index f4eee642e5ce..5280ffd77b39 100644
> --- a/drivers/net/wireless/realtek/rtw89/phy.c
> +++ b/drivers/net/wireless/realtek/rtw89/phy.c
> @@ -3535,6 +3535,7 @@ void rtw89_phy_c2h_handle(struct rtw89_dev *rtwdev, struct sk_buff *skb,
> {
> void (*handler)(struct rtw89_dev *rtwdev,
> struct sk_buff *c2h, u32 len) = NULL;
> + static DECLARE_BITMAP(printed_support, U8_MAX);
>
> switch (class) {
> case RTW89_PHY_C2H_CLASS_RA:
> @@ -3549,17 +3550,15 @@ void rtw89_phy_c2h_handle(struct rtw89_dev *rtwdev, struct sk_buff *skb,
> if (func < ARRAY_SIZE(rtw89_phy_c2h_rfk_report_handler))
> handler = rtw89_phy_c2h_rfk_report_handler[func];
> break;
> - case RTW89_PHY_C2H_CLASS_DM:
> - if (func == RTW89_PHY_C2H_DM_FUNC_LOWRT_RTY)
> - return;
> - fallthrough;
> default:
> - rtw89_info(rtwdev, "PHY c2h class %d not support\n", class);
> + if (!test_and_set_bit(class, printed_support))
> + rtw89_info(rtwdev, "PHY c2h class %d not supported\n",
> + class);
> return;
> }
> if (!handler) {
> - rtw89_info(rtwdev, "PHY c2h class %d func %d not support\n", class,
> - func);
> + rtw89_info(rtwdev, "PHY c2h class %d func %d not supported\n",
> + class, func);
> return;
> }
> handler(rtwdev, skb, len);
