On Tue, 2025-07-22 at 17:13 +0200, Martin Kaistra wrote:
> Hi Johannes,
>
> Am 22.07.25 um 14:11 schrieb Johannes Berg:
> > On Thu, 2025-07-10 at 09:47 +0200, Martin Kaistra wrote:
> > > Hi,
> > >
> > > when trying to use monitor mode with either rtl8xxxu or rtlwifi driver I get a
> > > "Failed check-sdata-in-driver check" warning in
> > > ieee80211_link_info_change_notify(). Aside from the warning, monitor mode seems
> > > to work fine. This might also affect other drivers, I just don't have the
> > > hardware to test.
> > >
> > > I bisected and found that the warning started with c4382d5ca1af ("wifi:
> > > mac80211: update the right link for tx power").
> > >
> > > I can make the warning go away when I add WANT_MONITOR_VIF to the driver, but
> > > the real fix should probably go in mac80211.
> >
> > Strange, I'm not sure I see the relation with the commit you mention.
>
> Before the mentioned commit __ieee80211_recalc_txpower() returns false and so
> ieee80211_link_info_change_notify() doesn't get called.
Hmm, still, I'm not sure I see why it changes anything for _monitor_
since those only have the deflink, so link[0] == &deflink and that
should've been the same all along?
Anyway ...
> I can confirm that with the code snippet (with an added curly brace) I don't get
> the warning anymore.
I guess it's a reasonable fix, I'll send a real patch.
johannes
