On 12/2/2022 9:06 PM, Christoph Hellwig wrote: > While ath11k_pci can load without qrtr-mhi, probing the actual hardware > will fail when qrtr and qrtr-mhi aren't loaded with > > failed to initialize qmi handle: -517 > > Add a MODULE_SOFTDEP statement to bring the module in (and as a hint > for kernel packaging) for those cases where it isn't autoloaded already > for some reason. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > --- > drivers/net/wireless/ath/ath11k/pci.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/wireless/ath/ath11k/pci.c b/drivers/net/wireless/ath/ath11k/pci.c > index 99cf3357c66e16..9d58856cbf8a94 100644 > --- a/drivers/net/wireless/ath/ath11k/pci.c > +++ b/drivers/net/wireless/ath/ath11k/pci.c > @@ -1037,6 +1037,8 @@ module_exit(ath11k_pci_exit); > MODULE_DESCRIPTION("Driver support for Qualcomm Technologies 802.11ax WLAN PCIe devices"); > MODULE_LICENSE("Dual BSD/GPL"); > > +MODULE_SOFTDEP("pre: qrtr-mhi"); > + > /* QCA639x 2.0 firmware files */ > MODULE_FIRMWARE(ATH11K_FW_DIR "/QCA6390/hw2.0/" ATH11K_BOARD_API2_FILE); > MODULE_FIRMWARE(ATH11K_FW_DIR "/QCA6390/hw2.0/" ATH11K_AMSS_FILE); Do we know why this patch is rejected?