On Fri, Jul 04, 2025 at 02:42:17PM -0700, Rosen Penev wrote: > This is used to override the various defaults the ath9k driver has for > LED pin values. > > Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx> > --- > .../bindings/net/wireless/qca,ath9k.yaml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml > index d16ca8e0a25d..58c7b873cecb 100644 > --- a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml > +++ b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml > @@ -50,6 +50,19 @@ properties: > > ieee80211-freq-limit: true > > + led: > + type: object > + $ref: /schemas/leds/common.yaml# > + additionalProperties: false You really don't want any other common properties? Like defining the function? > + properties: > + led-active-low: > + description: > + LED is enabled with ground signal. > + type: boolean > + > + led-sources: > + maxItems: 1 This property is really for cases where the LED source is configurable from the LED instance. If that's not the case here just use 'reg' for each instance (assuming there's more than 1). I shouldn't be wondering what the h/w looks like though. Please describe it in the commit msg rather than what some driver does. If you do need led-sources, you should define some constraints on the values, not just the length. Rob
