On 04/07/2025 06:36, Ping-Ke Shih wrote:
> Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote:
>> Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> wrote:
>>
>>> Make rtw8851b_read_efuse() accept USB devices and load the MAC address
>>> from the correct offset.
>>>
>>> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx>
>>> Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
>>
>> 14 patch(es) applied to rtw-next branch of rtw.git, thanks.
>>
>> 4b6ea5a38197 wifi: rtw89: 8851b: Accept USB devices and load their MAC address
>> ee47816f24a1 wifi: rtw89: Make dle_mem in rtw89_chip_info an array
>> 82870ba25f32 wifi: rtw89: Make hfc_param_ini in rtw89_chip_info an array
>> 3c63450c8723 wifi: rtw89: Add rtw8851b_dle_mem_usb{2,3}
>> 02a44c263031 wifi: rtw89: Add rtw8851b_hfc_param_ini_usb
>> a3b871a0f7c0 wifi: rtw89: Disable deep power saving for USB/SDIO
>> ec542d5e4bf6 wifi: rtw89: Add extra TX headroom for USB
>> 0740c6beefae wifi: rtw89: Hide some errors when the device is unplugged
>> e906a11753c9 wifi: rtw89: 8851b: Modify rtw8851b_pwr_{on,off}_func() for USB
>> e2b71603333a wifi: rtw89: Fix rtw89_mac_power_switch() for USB
>> ed88640ea1ac wifi: rtw89: Add some definitions for USB
>> bd569751baff wifi: rtw89: Add usb.{c,h}
>
> My work flow missed to build newly added usb.c, causing sparse warning.
>
> Fixed by:
>
> diff --git a/drivers/net/wireless/realtek/rtw89/usb.c b/drivers/net/wireless/realtek/rtw89/usb.c
> index 72870a80f801..6cf89aee252e 100644
> --- a/drivers/net/wireless/realtek/rtw89/usb.c
> +++ b/drivers/net/wireless/realtek/rtw89/usb.c
> @@ -210,7 +210,7 @@ static void rtw89_usb_write_port_complete(struct urb *urb)
> txdesc = (struct rtw89_txwd_body *)skb->data;
>
> txdesc_size = rtwdev->chip->txwd_body_size;
> - if (u32_get_bits(txdesc->dword0, RTW89_TXWD_BODY0_WD_INFO_EN))
> + if (le32_get_bits(txdesc->dword0, RTW89_TXWD_BODY0_WD_INFO_EN))
> txdesc_size += rtwdev->chip->txwd_info_size;
>
> skb_pull(skb, txdesc_size);
>
> And push out (force update):
>
> ed88640ea1ac wifi: rtw89: Add some definitions for USB
> 2135c28be6a8 wifi: rtw89: Add usb.{c,h}
> 52cf44323785 wifi: rtw89: Add rtw8851bu.c
> 0030088148d5 wifi: rtw89: Enable the new USB modules
>
Thank you for fixing that. I ran sparse on v3, but I must have forgotten
to run it on v4.
