On 6/26/2025 11:18 AM, Jeff Johnson wrote:
> On 6/26/2025 10:20 AM, Vasanthakumar Thiagarajan wrote:
>> On 6/17/2025 4:51 PM, Roopni Devanathan wrote:
>>> From: Saleemuddin Shaik <quic_saleemud@xxxxxxxxxxx>
>>> +struct ath12k_htt_tx_histogram_stats_tlv {
>>> + __le32 rate_retry_mcs_drop_cnt;
>>> + __le32 mcs_drop_rate[ATH12K_HTT_TX_PDEV_STATS_NUM_MCS_DROP_COUNTERS];
>>> + __le32 per_histogram_cnt[ATH12K_HTT_TX_PDEV_STATS_NUM_PER_COUNTERS];
>>> + __le32 low_latency_rate_cnt;
>>> + __le32 su_burst_rate_drop_cnt;
>>> + __le32 su_burst_rate_drop_fail_cnt;
>>> +};
>>
>> Since this strcuture represents the message format used between host and firmware, pls add
>> __packed annotation even though it may not have any effect in this case.
>
> looks like I missed this in a few other structs as well, at least:
> ath12k_htt_tx_pdev_rate_stats_tlv
> ath12k_htt_rx_pdev_rate_ext_stats_tlv
>
> perhaps i'll take this as-is and then have another patch that adds __packed to
> all _tlv structs that are missing it?
actually let me fix this instance in pending, and we can fix other existing
ones separately
/jeff
