On Tue, 2025-06-24 at 10:26 -0700, Jeff Johnson wrote: > On 6/24/2025 9:50 AM, Govind Singh wrote: > > This patch adds two module parameters to the ath12k PCI driver. > > Please use imperative voice. > And it is preferential to first describe the problem, and then describe the > proposed solution. > > > > > - ath12k_msi_mode: Allows selecting the MSI allocation mode. > > * 0 = multi-vector MSI (default) > > * 1 = single-vector MSI > > > > - ath12k_32bit_msi: Forces the use of 32-bit MSI addressing > > by setting pdev->no_64bit_msi = 1 before IRQ vector allocation. > > > > These options are useful for working around hardware or platform > > limitations(ex: i.MX 8M Plus) where 64-bit MSI or multi-vector MSI > > allocations fails or cause stability issues. > > So there is no way to detect this? For the record, Jakub has very much been pushing back against new module parameters, so I don't think we should take this. johannes
