On Mon, 2025-06-09 at 12:33 +0530, Maharaja Kennadyrajan wrote: > > +static bool > +ieee80211_is_all_links_timed_out(struct ieee80211_sub_if_data *sdata, > + unsigned long *latest_timeout) That really could use a better name - "are all links timed out", at least, but what does it even mean that "a link timed out"? You mean something more specific, surely? Also maybe we can encode the bool return value in a special timeout value, say 0, and just make sure 0 is never otherwise returned by adjusting by a jiffy or so? Not sure, just seems a bit annoying to have both, but maybe it's worth it. > - if (sdata->vif.bss_conf.csa_active && > - !sdata->deflink.u.mgd.csa.waiting_bcn) > - return; > + unsigned long latest_timeout = 0; > + bool all_links_timed_out = true; You don't need to initialise something > - /* If timeout is after now, then update timer to fire at > + all_links_timed_out = ieee80211_is_all_links_timed_out(sdata, > + &latest_timeout); that you're going to unconditionally initialise anyway johannes
