On Wed, 2025-05-28 at 11:14 +0530, Sarika Sharma wrote: > Current implementation of NL80211_CMD_GET_STATION does not work > for multi-link operation(MLO) since in case of MLO only deflink > (or one of the links) is considered and not all links. > > Hence, add the link_sinfo structure to provide infrastructure > for link-level station statistics for multi-link operation(MLO). > > Additionally, accumulated stats for MLO are included in a concise > manner to provide a comprehensive overview of the ML stations. > > V10: > - Add WARN_ON_ONCE(!link_sinfo), if valid links. > - Fixed kernel doc error. > - Corrected logic for setting sinfo->valid_links only if memory is > allocated for link_sinfo. > I'm going to apply this because we're at v10 and I'm losing track of all the changes etc., but while looking through it now, here are a couple of things I think you/we should still change: - We already require a call to allocate TID stats, I think it'd make sense to also do that for link stats, instead of allocating _all_ of them always. The cfg80211_link_sinfo_alloc_tid_stats() could go away in favour of cfg80211_sinfo_allocate_link() that gets an argument 'bool tidstats' to allocate (or not) TID stats with it - I still don't like patch 7, I think that should be a WARN_ON_ONCE or so and the producers shouldn't be creating that in the first place, otherwise reading the mac80211 code is misleading since you don't even get that data. Also the producers shouldn't even _have_ valid data for these values. - What about TX statistics, we still have these patches: https://lore.kernel.org/linux-wireless/20241218232519.3156080-1-greearb@xxxxxxxxxxxxxxx/ which is still needed, right? johannes
