On Wed, 11 Jun 2025 11:35:18 +0200 Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > Hi, > Hello, Thank you for the review and sorry for such a late response. > So ... I have no idea why you're CC'ing all kinds of people who never > had anything to do with this driver, or haven't worked on WiFi in > like a decade or so ... Please don't. Even I should've been CC'ed > with a different address, at most. > > I also have no idea who's maintaining this driver now though, if > anyone. I have hardware if someone wants it ;-) > Also, sorry for the mess with the CC list. The driver is marked as "Orphaned" now and this is the first time I am trying to send a patch for an orphaned driver. MAINTAINERS file only gives the Wireless mailing list and the rest of CC list was generated by get_maintainer.pl script. I could not find any relevant information on how to send patches for orphaned drivers in kernel docs. Can you, please, give me some advice on a process of submitting patches to orphaned drivers or, if there is any relevant documentation on the topic, can you share a link? > > In order to avoid potential data races and leading dereference of a > > NULL pointer, acquire the queue lock before any work with the queue > > is done and replace all skb_* calls with their lockless version. > > You should explain why the locking changes are OK. > Ok, I'll improve the patch description, thank you! > johannes Kind regards, Daniil Dulov