From: Yuuki NAGAO <wf.yn386@xxxxxxxxx> [ Upstream commit b7f0cc647e52296a3d4dd727b6479dcd6d7e364e ] Add VID/PID 0411/03d1 for recently released BUFFALO WI-U2-866DM USB WiFi adapter. Signed-off-by: Yuuki NAGAO <wf.yn386@xxxxxxxxx> Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> Link: https://patch.msgid.link/20250503003227.6673-1-wf.yn386@xxxxxxxxx Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> --- Based on my analysis of the commit and comparison with the similar commits provided, here is my assessment: **YES** This commit should be backported to stable kernel trees for the following reasons: ## Analysis **1. Hardware Support Addition**: This commit adds VID/PID 0411/03d1 for the Buffalo WI-U2-866DM USB WiFi adapter to the rtw8822bu driver. This is a straightforward device identification addition that enables hardware support for users who have this specific device. **2. Code Changes Analysis**: The change is minimal and extremely low-risk: - **Single line addition**: Only adds one USB device table entry at line 80-81 in `/drivers/net/wireless/realtek/rtw88/rtw8822bu.c` - **No functional code changes**: No modifications to driver logic, algorithms, or behavior - **Standard pattern**: Uses the exact same pattern as all other device entries in the table - **Reuses existing hardware specification**: Points to the same `rtw8822b_hw_spec` used by other 8822bu devices **3. Comparison with Similar Commits**: - **Similar Commit #1** (Status: YES): Removing incorrect VID/PID had `Cc: stable@xxxxxxxxxxxxxxx` and was backported - **Similar Commit #3** (Status: YES): Adding missing VID/PIDs for 8811CU and 8821CU had `Cc: stable@xxxxxxxxxxxxxxx` and was backported - **Similar Commit #5** (Status: YES): Adding Buffalo WLI-UC-G450 device had `Cc: stable@xxxxxxxxxxxxxxx` and was backported **4. Buffalo Device Pattern**: The git history shows Buffalo devices with vendor ID 0x0411 are commonly supported across multiple rtw88 drivers (rtw8812au.c, rtw8821au.c, and now rtw8822bu.c), indicating this is a legitimate and expected device addition. **5. User Impact**: Users with this specific Buffalo USB WiFi adapter will have working WiFi support instead of non- functional hardware. This fixes a user-visible issue where the device is not recognized. **6. Stable Tree Criteria Met**: - ✅ **Important bugfix**: Enables hardware support for affected users - ✅ **Small and contained**: Single line addition, no behavior changes - ✅ **Minimal regression risk**: Cannot break existing functionality - ✅ **Confined to subsystem**: Only affects USB device identification in rtw88 - ✅ **Clear benefit**: Enables WiFi functionality for specific hardware **7. Missing Stable Tag**: While the original commit lacks an explicit `Cc: stable@xxxxxxxxxxxxxxx` tag, this appears to be an oversight given that similar commits in the same subsystem (commits 0af8cd2822f3 and b8a62478f3b1) included stable tags for nearly identical device addition changes. The change is essentially risk-free as it only extends hardware compatibility without affecting any existing code paths or device support. drivers/net/wireless/realtek/rtw88/rtw8822bu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822bu.c b/drivers/net/wireless/realtek/rtw88/rtw8822bu.c index 572d1f31832ee..ab50b3c405626 100644 --- a/drivers/net/wireless/realtek/rtw88/rtw8822bu.c +++ b/drivers/net/wireless/realtek/rtw88/rtw8822bu.c @@ -77,6 +77,8 @@ static const struct usb_device_id rtw_8822bu_id_table[] = { .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* Mercusys MA30N */ { USB_DEVICE_AND_INTERFACE_INFO(0x2001, 0x3322, 0xff, 0xff, 0xff), .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* D-Link DWA-T185 rev. A1 */ + { USB_DEVICE_AND_INTERFACE_INFO(0x0411, 0x03d1, 0xff, 0xff, 0xff), + .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* BUFFALO WI-U2-866DM */ {}, }; MODULE_DEVICE_TABLE(usb, rtw_8822bu_id_table); -- 2.39.5
