On 5/22/2025 1:01 PM, Rodrigo Gobbi wrote: > if ath11k_crypto_mode is invalid (not ATH11K_CRYPT_MODE_SW/ATH11K_CRYPT_MODE_HW), > ath11k_core_qmi_firmware_ready() will not undo some actions that was previously > started/configured. Do the validation as soon as possible in order to avoid > undoing actions in that case and also to fix the following smatch warning: > > drivers/net/wireless/ath/ath11k/core.c:2166 ath11k_core_qmi_firmware_ready() > warn: missing unwind goto? > > Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@xxxxxxxxx> Since this issue was previously reported, I'm adding: Reported-by: kernel test robot <lkp@xxxxxxxxx> Reported-by: Dan Carpenter <error27@xxxxxxxxx> Closes: https://lore.kernel.org/r/202304151955.oqAetVFd-lkp@xxxxxxxxx/ Fixes: aa2092a9bab3 ("ath11k: add raw mode and software crypto support")
