On 23/05/2025 02:04, Rosen Penev wrote: > On Thu, May 22, 2025 at 12:54 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: >> >> On 22/05/2025 20:45, Rosen Penev wrote: >>> Now that support was added to the driver, document it. >> >> That's not appropriate commit msg. Binding must be before the user (see >> submitting patches in DT directory). Describe the hardware, what are you >> adding here. >> >> Subject: OF bindings is redundant. It duplicates dt-bindings. Instead: >> "Add Atheros AR9-foo-bar on AHB bus" or something similar > At this point I wonder if my approach is wrong. The other ath drivers > use a qcom, prefix and a -wifi suffix. Might make sense to do the same > here to avoid typing qca twice. Yes, probably this should be qcom. Best regards, Krzysztof
