On Thu, 2025-05-22 at 12:49 +0200, Felix Fietkau wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> On 21.03.25 02:38, Mingyen Hsieh wrote:
> > From: Ming Yen Hsieh <mingyen.hsieh@xxxxxxxxxxxx>
> >
> > Enhance the mt7925 to include RNR scan support. It adds
> > the necessary RNR information to the scan command.
> >
> > Signed-off-by: Ming Yen Hsieh <mingyen.hsieh@xxxxxxxxxxxx>
> > ---
> > v2:
> > - use '= {}' to replace the '= {0}' for short_ssid array.
> > - align with the open paranthesis for crc32_le.
> > - use ether_addr_copy() to replace the memcpy of bssid.
> > ---
> > .../net/wireless/mediatek/mt76/mt7925/mcu.c | 36
> > ++++++++++++++++---
> > .../net/wireless/mediatek/mt76/mt7925/mcu.h | 17 +++++----
> > 2 files changed, 41 insertions(+), 12 deletions(-)
> >
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
> > b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
> > index 243adace8799..22686faca1af 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
> > @@ -3078,7 +3079,11 @@ int mt7925_mcu_hw_scan(struct mt76_phy *phy,
> > struct ieee80211_vif *vif,
> > for (i = 0; i < sreq->n_ssids; i++) {
> > if (!sreq->ssids[i].ssid_len)
> > continue;
> > + if (i > MT7925_RNR_SCAN_MAX_BSSIDS)
> > + break;
> >
> > + short_ssid[i] = ~crc32_le(~0, sreq->ssids[i].ssid,
> > + sreq->ssids[i].ssid_len);
>
> I had to remove this variable due to a unused-but-set warning. I'm
> not
> sure if the contents of it should have been stored somewhere in the
> MCU
> message, or if this was something that ended up not being necessary.
> Please review and send a follow-up fix if needed.
>
> - Felix
Hi Felix,
This variable is currently not being used. I apologize for my oversight
that caused this warning. Should i submit a v3 to remove it, or will
you help remove it?
Yen.
