On Thu, 2025-05-22 at 14:33 +0530, Sarika Sharma wrote:
>
> > + if (sinfo->valid_links) {
> > + links = nla_nest_start(msg, NL80211_ATTR_MLO_LINKS);
> > + if (!links)
> > + goto nla_put_failure;
> > +
> > + for_each_valid_link(sinfo, link_id) {
> > + link_sinfo = sinfo->links[link_id];
> > +
> > + if (!link_sinfo)
> > + continue;
>
> I have removed the WARN_ON_ONCE() check for !link_sinfo because
> link_sinfo can be NULL during sta_destroy.
> It appears that nl80211_dump_station is being invoked during sta
> destroy, though it's not very clear why this happens in that context.
> Introduced in patch " mac80211: avoid excessive stack usage in sta_info".
>
> Since link_sinfo memory isn't allocated during sta_destroy, there's a
> valid chance it remains uninitialized,
> which triggers the WARN_ON_ONCE() and causes hw_sim test cases to fail.
>
> Let me know if I am missing the requirement to allocate link_sinfo
> memory during sta destroy.
Probably not, though maybe we do want the link addresses in the station
delete message to userspace?
But the warning was just an inconsistency issue - why should users set
the valid bits for a link but then not have any link data? That seems
wrong?
johannes
