On 5/15/2025 5:06 PM, Johannes Berg wrote:
On Thu, 2025-05-15 at 11:19 +0530, Sarika Sharma wrote:
Currently, sinfo->filled is for set in sta_set_sinfo() after filling
the corresponding fields in station_info structure for station statistics.
For non-ML stations, the fields are correctly filled from sta->deflink
and corresponding sinfo->filled bit are set, but for MLO any one of
link's data is filled and corresponding sinfo->filled bit is set.
For MLO before embed NL message, fields of sinfo structure like
bytes, packets, signal are updated with accumulated, best, least of all
links data. But some of fields like rssi, pertid don't make much sense
at MLO level.
Hence, to prevent misinterpretation, reset sinfo->filled for fields
^^^^^ clear?
which don't make much sense at MLO level. This will prevent filling the
unnecessary values in NL message.
Not sure I'd say "unnecessary" but perhaps misleading? I'm also not sure
this shouldn't be WARN_ON, we're throwing away data that was provided.
In mac80211 it even allocates tidstats memory for nothing, in this case,
that's super weird?
I reviewed the code again to check for pertid and realized that it is
applicable at the MLO level as well. The rx, tx fields are reported per
link (which can be accumulated for the MLO level), while the TXQ_STATS
related fields are applicable for station level meaning MLO level.
Therefore, pertid is applicable at MLO level and also at link level for
rx/tx fields.
Let me add code for it and send the version 9?
johannes
