Re: [PATCH v2] wifi: rtw88: fix the 'para' buffer size to avoid reading out of bounds

[Ping-Ke Shih <pkshih@xxxxxxxxxxx>]

Alexey Kodanev <aleksei.kodanev@xxxxxxxxxxx> wrote:

> Set the size to 6 instead of 2, since 'para' array is passed to
> 'rtw_fw_bt_wifi_control(rtwdev, para[0], &para[1])', which reads
> 5 bytes:
> 
> void rtw_fw_bt_wifi_control(struct rtw_dev *rtwdev, u8 op_code, u8 *data)
> {
>     ...
>     SET_BT_WIFI_CONTROL_DATA1(h2c_pkt, *data);
>     SET_BT_WIFI_CONTROL_DATA2(h2c_pkt, *(data + 1));
>     ...
>     SET_BT_WIFI_CONTROL_DATA5(h2c_pkt, *(data + 4));
> 
> Detected using the static analysis tool - Svace.
> Fixes: 4136214f7c46 ("rtw88: add BT co-existence support")
> Signed-off-by: Alexey Kodanev <aleksei.kodanev@xxxxxxxxxxx>

1 patch(es) applied to rtw-next branch of rtw.git, thanks.

4c2c372de2e1 wifi: rtw88: fix the 'para' buffer size to avoid reading out of bounds

---
https://github.com/pkshih/rtw.git