On 5/15/2025 6:10 AM, Rodrigo Gobbi wrote:
if ath11k_crypto_mode is invalid (not ATH11K_CRYPT_MODE_SW/ATH11K_CRYPT_MODE_HW), ath11k_core_qmi_firmware_ready() will not undo some actions that was previously started/configured. It's reasonable to undo things during this condition, despite the value used at ath11k_crypto_mode not being valid in this case. Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@xxxxxxxxx> --- Smatch got the following error: drivers/net/wireless/ath/ath11k/core.c:2166 ath11k_core_qmi_firmware_ready() warn: missing unwind goto?
This warning message can be included in the commit message itself.
When the ath11k_crypto_mode, which is a module param, is not ATH11K_CRYPT_MODE_SW/HW, clean-up actions are not triggered. Considering the whole ath11k_core_qmi_firmware_ready() function, during potential errors, those actions are properly triggered. I'm suggesting a little change over the default case to clean things up. Tks and regards.
This can be dropped as it does not provide any additional information. Vasanth
