Search Linux Wireless

Re: [PATCH wireless-next v8 02/10] wifi: cfg80211: add link_station_info structure to support MLO statistics

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/15/2025 4:56 PM, Johannes Berg wrote:
On Thu, 2025-05-15 at 11:18 +0530, Sarika Sharma wrote:

+/**
+ * struct link_station_info - link station information
+ *
+ * Link station information filled by driver for get_station() and
+ *	dump_station().
+ * @link_id: Link ID uniquely identifying the link STA. This is -1 for non-ML

Oh also, the link_id shouldn't be in here, the documentation is wrong (-
1 is never used that way), and it's already indexed by link ID so it's
just a source of errors to have two values that should be the same...


Sure, was using in previous design to check for deflink, here we can directly use from link_sta.
Let me remove it and use existing link_id.

And yes this implies changes to patch 9, but those are _good_, having
the link ID implicit in the output structure seems awkward.

Okay, sure.


johannes





[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux