Search Linux Wireless

Re: [PATCH wireless-next v8 06/10] wifi: mac80211: add support to accumulate removed link statistics

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Also,

On Thu, 2025-05-15 at 11:19 +0530, Sarika Sharma wrote:
> 
> +static void sta_accumulate_removed_link_stats(struct sta_info *sta, int link_id)
> +{
> +	struct link_sta_info *link_sta = wiphy_dereference(sta->local->hw.wiphy,
> +							   sta->link[link_id]);
> +	int ac;
> +
> +	for (ac = 0; ac < IEEE80211_NUM_ACS; ac++) {
> +		sta->rem_link_stats.tx_packets +=
> +			link_sta->tx_stats.packets[ac];
> +		sta->rem_link_stats.tx_bytes += link_sta->tx_stats.bytes[ac];

It seems odd to take per-AC values and flatten them in this case? How do
they even get reported, as overall values only? Then you get the same
inconsistency again on per-AC values since those are (or at least
could/should be) summed up over all links, but aren't kept post removal?

johannes





[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux