Search Linux Wireless

Re: [PATCH wireless-next 1/2] wifi: mac80211: validate SCAN_FLAG_AP in scan request during MLO

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/13/2025 12:47 PM, Johannes Berg wrote:
On Tue, 2025-05-13 at 09:26 +0530, Aditya Kumar Singh wrote:

-		if (sdata->deflink.u.ap.beacon &&
+		if ((sdata->deflink.u.ap.beacon ||
+		     ieee80211_num_beaconing_links(sdata)) &&


Do we even still need the deflink check? Seems like
num_beaconing_links() _should_ return 1 anyway even though it currently
doesn't, and we need to fix that?

If the ieee80211_num_beaconing_links() is modified then deflink check is not required. Do you want to me to send a clean up for that function first or would take this and later the clean up part?


Also seems the VLAN carrier handling is broken.
With this patch? Or in general you are saying? HWSIM test cases seems to be working fine for me with this series applied. May be there is no test case to make it evident?

--
Aditya




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux