Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> wrote:
> Clear some bits in some registers in order to allow RTL8851BU to power
> on. Also tested with RTL8832BU and RTL8832CU.
I see mac_pwr_on_pcie_8851b() and mac_pwr_on_usb_8851b() at least in
vendor driver. If you use the power on/off functions for USB devices,
the problem may disappear.
>
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx>
> ---
> drivers/net/wireless/realtek/rtw89/mac.c | 8 ++++++++
> drivers/net/wireless/realtek/rtw89/reg.h | 1 +
> 2 files changed, 9 insertions(+)
>
> diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c
> index 99f01fff90fe..d3cf67dfabc9 100644
> --- a/drivers/net/wireless/realtek/rtw89/mac.c
> +++ b/drivers/net/wireless/realtek/rtw89/mac.c
> @@ -1458,6 +1458,14 @@ static int rtw89_mac_power_switch(struct rtw89_dev *rtwdev, bool on)
> int ret;
> u8 val;
>
> + if (rtwdev->hci.type == RTW89_HCI_TYPE_USB &&
> + rtw89_read32_mask(rtwdev, R_AX_GPIO_MUXCFG, B_AX_BOOT_MODE)) {
Not prefer calling a function in if-statement. Suggest to add a function.
> + rtw89_write32_clr(rtwdev, R_AX_SYS_PW_CTRL, B_AX_APFN_ONMAC);
> + rtw89_write32_clr(rtwdev, R_AX_SYS_STATUS1, B_AX_AUTO_WLPON);
> + rtw89_write32_clr(rtwdev, R_AX_GPIO_MUXCFG, B_AX_BOOT_MODE);
> + rtw89_write32_clr(rtwdev, R_AX_RSV_CTRL, B_AX_R_DIS_PRST);
> + }
> +
> if (on) {
> cfg_seq = chip->pwr_on_seq;
> cfg_func = chip->ops->pwr_on_func;
