Re: [PATCH wireless-next v6 05/11] wifi: cfg80211: extend statistics for link level in sinfo

[Sarika Sharma <quic_sarishar@xxxxxxxxxxx>]

On 5/7/2025 6:23 PM, Johannes Berg wrote:
> On Tue, 2025-04-15 at 09:50 +0530, Sarika Sharma wrote:
> > The statistics will be embedded into NL message as below:
> > For MLO:
> > cmd ->
> >      NL80211_ATTR_IFINDEX
> >      NL80211_ATTR_MAC
> >      NL80211_ATTR_GENERATION
> >      .......etc
> >      NL80211_ATTR_STA_INFO | nested
> >          NL80211_STA_INFO_CONNECTED_TIME,
> >          NL80211_STA_INFO_STA_FLAGS,
> >          ........etc                              // <--- here
> >      NL80211_ATTR_MLO_LINK_ID,
> >      NL80211_ATTR_MLD_ADDR,
> >      NL80211_ATTR_MLO_LINKS | nested
> >          link_id-1 | nested
> >              NL80211_ATTR_MLO_LINK_ID,
> >              NL80211_ATTR_MAC,
> >              NL80211_ATTR_STA_INFO | nested
> >                  NL80211_STA_INFO_RX_BYTES,
> >                  NL80211_STA_INFO_TX_BYTES,
> >                 ..........etc.
> >          link_id-2 | nested
> >              NL80211_ATTR_MLO_LINK_ID,
> >              NL80211_ATTR_MAC,
> >              NL80211_ATTR_STA_INFO | nested
> >                  NL80211_STA_INFO_RX_BYTES,
> >                  NL80211_STA_INFO_TX_BYTES,
> >                  .........etc
>
> FWIW, this seems fine to me. Maybe at least we can quickly agree on the
> API here.
>
> I think NL80211_STA_INFO_CONNECTED_TIME might make sense for individual
> links as well, if we track that, since we can use multi-link
> reconfiguration to add links later after the connection. So might be
> interesting to have that per link in that scenario.

Yes, I added connected time, for link level as well in link_station_info 
structure.

> You also add later the accumulated statistics where I put the "here"
> marker.

Yes.
> johannes