Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> wrote: > On 05/05/2025 03:45, Ping-Ke Shih wrote: > > Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> wrote: > >> Use the same RX aggregation size and timeout used by the out-of-tree > >> RTL8723DS driver. Also set mystery bit 31 of REG_RXDMA_AGG_PG_TH. This > >> improves the RX speed from ~44 Mbps to ~67 Mbps. > >> > >> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> > >> --- > >> v2: > >> - Restore the original behaviour for RTL8821A and RTL8812A. > > > > This patch actually restores the behavior of RTL8821A and RTL8812A. But > > they are 802.11ac chips [1] [2], somehow defined as RTW_WCPU_11N. > > > > I can accept this patch ahead. Please help to think how we can correct > > this mistake. > > > > Yes, the enums RTW_WCPU_11AC and RTW_WCPU_11N have wrong names. > RTL8821A and RTL8812A are 11ac chips but their MCU is the > RTW_WCPU_11N type. RTL8733BU (not supported in rtw88) is 11n but its > MCU is the RTW_WCPU_11AC type. > > I was thinking to rename them: > > RTW_WCPU_11N -> RTW_WCPU_8051 > RTW_WCPU_11AC -> RTW_WCPU_3081 > > 8051 and 3081 are the names used in the vendor drivers: > > #define PHYDM_IC_8051_SERIES (ODM_RTL8881A | ODM_RTL8812 | ODM_RTL8821 |\ > ODM_RTL8192E | ODM_RTL8723B | ODM_RTL8703B |\ > ODM_RTL8188F | ODM_RTL8192F | ODM_RTL8721D |\ > ODM_RTL8710C) > #define PHYDM_IC_3081_SERIES (ODM_RTL8814A | ODM_RTL8822B | ODM_RTL8197F |\ > ODM_RTL8821C | ODM_RTL8195B | ODM_RTL8198F |\ > ODM_RTL8822C | ODM_RTL8812F | ODM_RTL8814B |\ > ODM_RTL8197G) Thanks. Please help making a patch.
