On Wed, 2025-04-30 at 14:26 +0200, Johannes Berg wrote:
> On Wed, 2025-04-30 at 12:25 +0000, Maharaja Kennadyrajan wrote:
> > >
> > > > + if (valid_links) {
> > > > + for_each_set_bit(link_id, &valid_links,
> > > > + IEEE80211_MLD_MAX_NUM_LINKS) {
> > >
> > > We just added some for_each_sdata_link() macro or so, so you don't need the
> > > distinction between MLO and non-MLO. I really don't like seeing that, if we do
> > > that all the time we have far too many places that would do it.
> > >
> >
> > We have to loop over the links of sdata here. So shall we use this API for_each_link_data() instead of for_each_sdata_link?
> >
>
> Yeah you can use for_each_sdata_link()? But you didn't.
>
Err, no. Naming. That iterates _all_ links of _all_ interfaces for the
entire wiphy.
You should use for_each_link_data().
johannes
