> > Since you have duplicated arrays of channels and bitrate, we should add const
> > to them, like:
> >
> > static const struct ieee80211_channel rtw89_channels_{2ghz,5ghz,6ghz}[]
> > static const struct ieee80211_rate rtw89_bitrates[]
>
> That will produce:
>
> initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>
> warnings, because struct ieee80211_supported_band doesn't have these fields
> as const. The discarding of const qualifiers is apparently safe in this case,
> so I can either cast the pointers to non-const when assigned here:
>
> 270 static const struct ieee80211_supported_band rtw89_sband_2ghz = {
> 271 .band = NL80211_BAND_2GHZ,
> 272 .channels = rtw89_channels_2ghz,
> 273 .n_channels = ARRAY_SIZE(rtw89_channels_2ghz),
> 274 .bitrates = rtw89_bitrates,
> 275 .n_bitrates = ARRAY_SIZE(rtw89_bitrates),
> 276 .ht_cap = {0},
> 277 .vht_cap = {0},
> 278 };
>
Ah. I was not aware of this point. Please keep it as was.
