On Wed, 2025-04-23 at 23:21 +0530, Gokul Sivakumar wrote: > > +static int brcmf_cfg80211_change_bss(struct wiphy *wiphy, struct net_device *dev, > + struct bss_parameters *params) > +{ > + struct brcmf_if *ifp = netdev_priv(dev); > + int ret = 0; > + > + /* In AP mode, the "ap_isolate" value represents > + * 0 = allow low-level bridging of frames between associated stations > + * 1 = restrict low-level bridging of frames to isolate associated stations > + * -1 = do not change existing setting > + */ > + if (params->ap_isolate >= 0) { > + ret = brcmf_fil_iovar_int_set(ifp, "ap_isolate", params->ap_isolate); > + if (ret < 0) > + brcmf_err("ap_isolate iovar failed: ret=%d\n", ret); > + } > + > + return ret; > +} Seems like a terrible idea to accept any other changes silently without doing anything at all. Also, please pay attention to the linux-wireless list. Like, at all. We started using tree tags months ago, we started using a different subject prefix _years_ ago. johannes