Search Linux Wireless

Re: [PATCHv2] wifi: ath9k: ahb: do ioremap resource in one step

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Rosen Penev <rosenp@xxxxxxxxx> writes:

> Simplifies probe slightly and adds extra error codes.
>
> Switching from devm_ioremap to the platform variant ends up calling
> devm_request_mem_region, which reserves the memory region for the
> various wmacs. Per board, there is only one wmac and after some fairly
> thorough analysis, there are no overlapping memory regions between wmacs
> and other devices on the ahb.
>
> Tested on a TP-Link Archer C7v2.
>
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> ---
>  v2: remove wrong devm irq conversion.
>  drivers/net/wireless/ath/ath9k/ahb.c | 13 +++----------
>  1 file changed, 3 insertions(+), 10 deletions(-)

Is there any benefit from this other than code simplification? Because,
TBH, I'm not sure saving 7 lines of code is worth the risk of changing
something we know works already...

-Toke




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux