Re: [PATCH] [PATCH v2] wifi: mt76x2: Add support for LiteOn WN4516R and WN4519R

[Henk Vergonet <henk.vergonet@xxxxxxxxx>]

Hi Lorenzo!

I am getting a little better at this now :)
v3 is on the list.

Thank you for the support!

On 4/18/25 16:18, Lorenzo Bianconi wrote:
> > Ads support for:
> >   - LiteOn WN4516R
> >   - LiteOn WN4519R
> >   Both use:
> >   - A nonstandard USB connector
> >   - Mediatek chipset MT7600U
> >   - ASIC revision: 76320044
> >
> > Disabled VHT support on ASIC revision 76320044:
> Just a couple of nits inline. After fixing them please add my Acked-by
>
> Acked-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
>
> >   This fixes the 5G connectibity issue on LiteOn WN4519R module
> >   see https://github.com/openwrt/mt76/issues/971
> >
> >   And may also fix the 5G issues on the XBox One Wireless Adapter
> >   see https://github.com/openwrt/mt76/issues/200
> >
> >   I have looked at the FCC info related to the MT7632U chip as mentioned in here:
> >   https://github.com/openwrt/mt76/issues/459
> >   These confirm the chipset does not support 'ac' mode and hence VHT should be turned of.
> >
> > Signed-off-by: Henk Vergonet <henk.vergonet@xxxxxxxxx>
> > ---
> >   drivers/net/wireless/mediatek/mt76/mt76x2/usb.c      |  2 ++
> >   drivers/net/wireless/mediatek/mt76/mt76x2/usb_init.c | 12 +++++++++++-
> >   2 files changed, 13 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2/usb.c b/drivers/net/wireless/mediatek/mt76/mt76x2/usb.c
> > index 84ef80ab4afb..96cecc576a98 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt76x2/usb.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mt76x2/usb.c
> > @@ -17,6 +17,8 @@ static const struct usb_device_id mt76x2u_device_table[] = {
> >   	{ USB_DEVICE(0x057c, 0x8503) },	/* Avm FRITZ!WLAN AC860 */
> >   	{ USB_DEVICE(0x7392, 0xb711) },	/* Edimax EW 7722 UAC */
> >   	{ USB_DEVICE(0x0e8d, 0x7632) },	/* HC-M7662BU1 */
> > +	{ USB_DEVICE(0x0471, 0x2126) }, /* LiteOn WN4516R module, nonstandard USB connector */
> > +	{ USB_DEVICE(0x0471, 0x7600) }, /* LiteOn WN4519R module, nonstandard USB connector */
> >   	{ USB_DEVICE(0x2c4e, 0x0103) },	/* Mercury UD13 */
> >   	{ USB_DEVICE(0x0846, 0x9014) },	/* Netgear WNDA3100v3 */
> >   	{ USB_DEVICE(0x0846, 0x9053) },	/* Netgear A6210 */
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2/usb_init.c b/drivers/net/wireless/mediatek/mt76/mt76x2/usb_init.c
> > index 33a14365ec9b..eb5e957f2f1b 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt76x2/usb_init.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mt76x2/usb_init.c
> > @@ -191,6 +191,7 @@ int mt76x2u_register_device(struct mt76x02_dev *dev)
> >   {
> >   	struct ieee80211_hw *hw = mt76_hw(dev);
> >   	struct mt76_usb *usb = &dev->mt76.usb;
> > +	bool vht;
> >   	int err;
> >   
> >   	INIT_DELAYED_WORK(&dev->cal_work, mt76x2u_phy_calibrate);
> > @@ -217,7 +218,16 @@ int mt76x2u_register_device(struct mt76x02_dev *dev)
> >   
> >   	/* check hw sg support in order to enable AMSDU */
> >   	hw->max_tx_fragments = dev->mt76.usb.sg_en ? MT_TX_SG_MAX_SIZE : 1;
> > -	err = mt76_register_device(&dev->mt76, true, mt76x02_rates,
> > +	switch (dev->mt76.rev) {
> > +		/* these ASIC revisions do not support VHT */
> please move this comment in the proper case.
>
> > +	case 0x76320044:
> > +		vht = false;
> > +		break;
> > +	default:
> > +		vht = true;
> > +		break;
> > +	}
> since you are reposting, can you please add a new-line here?
>
> > +	err = mt76_register_device(&dev->mt76, vht, mt76x02_rates,
> >   				   ARRAY_SIZE(mt76x02_rates));
> >   	if (err)
> >   		goto fail;
> > --
> > 2.45.2