Search Linux Wireless

RE: [PATCH -v2 2/2] wifi: rtw88: sdio: map mgmt frames to queue TX_DESC_QSEL_MGMT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Zhen XIN <zhen.xin@xxxxxxxxxxxxxxx> wrote:
> Rtw88-sdio do not work in AP mode due to the lack of tx status report for
> management frames.
> 
> Map the management frames to queue TX_DESC_QSEL_MGMT, which enables the
> chip to generate TX reports for these frames

I will change the order of this patch to first one, because with patch 1/2
only, it will throw many messages that times out to wait for TX reports
from firmware. 

By the way, patch subject should contain "rtw-next" as hint for NIPA to
test build [1]. This patchset is simple so it also work to build with
wireless-next.

[1] https://patchwork.kernel.org/project/linux-wireless/patch/20250410154217.1849977-3-zhen.xin@xxxxxxxxxxxxxxx/

> 
> Tested-on: rtl8723ds
> 
> Fixes: 65371a3f14e7 ("wifi: rtw88: sdio: Add HCI implementation for SDIO based chipsets")
> Signed-off-by: Zhen XIN <zhen.xin@xxxxxxxxxxxxxxx>
> ---
>  drivers/net/wireless/realtek/rtw88/sdio.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw88/sdio.c b/drivers/net/wireless/realtek/rtw88/sdio.c
> index ef51128a4b44..4311eb7cffef 100644
> --- a/drivers/net/wireless/realtek/rtw88/sdio.c
> +++ b/drivers/net/wireless/realtek/rtw88/sdio.c
> @@ -718,10 +718,7 @@ static u8 rtw_sdio_get_tx_qsel(struct rtw_dev *rtwdev, struct sk_buff *skb,
>         case RTW_TX_QUEUE_H2C:
>                 return TX_DESC_QSEL_H2C;
>         case RTW_TX_QUEUE_MGMT:
> -               if (rtw_chip_wcpu_11n(rtwdev))
> -                       return TX_DESC_QSEL_HIGH;
> -               else
> -                       return TX_DESC_QSEL_MGMT;
> +               return TX_DESC_QSEL_MGMT;
>         case RTW_TX_QUEUE_HI0:
>                 return TX_DESC_QSEL_HIGH;
>         default:
> --
> 2.25.1






[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux