> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of > Thomas Weißschuh > Sent: Monday, April 14, 2025 10:26 AM > To: Jeff Johnson <jjohnson@xxxxxxxxxx>; Loic Poulain > <loic.poulain@xxxxxxxxxx>; Brian Norris <briannorris@xxxxxxxxxxxx>; > Francesco Dolcini <francesco@xxxxxxxxxx>; Nguyen, Anthony L > <anthony.l.nguyen@xxxxxxxxx>; Kitszel, Przemyslaw > <przemyslaw.kitszel@xxxxxxxxx>; Andrew Lunn <andrew+netdev@xxxxxxx>; > David S. Miller <davem@xxxxxxxxxxxxx>; Dumazet, Eric > <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni > <pabeni@xxxxxxxxxx>; Saeed Mahameed <saeedm@xxxxxxxxxx>; Leon > Romanovsky <leon@xxxxxxxxxx>; Tariq Toukan <tariqt@xxxxxxxxxx> > Cc: ath10k@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > ath11k@xxxxxxxxxxxxxxxxxxx; ath12k@xxxxxxxxxxxxxxxxxxx; > wcn36xx@xxxxxxxxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; intel-wired- > lan@xxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; > Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx> > Subject: [Intel-wired-lan] [PATCH net-next 2/7] wifi: ath11k: Don't use %pK > through printk > > In the past %pK was preferable to %p as it would not leak raw pointer values > into the kernel log. > Since commit ad67b74d2469 ("printk: hash addresses printed with %p") the > regular %p has been improved to avoid this issue. > Furthermore, restricted pointers ("%pK") were never meant to be used > through printk(). They can still unintentionally leak raw pointers or acquire > sleeping looks in atomic contexts. > > Switch to the regular pointer formatting which is safer and easier to reason > about. > There are still a few users of %pK left, but these use it through seq_file, for > which its usage is safe. > > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@xxxxxxxxx> > --- > drivers/net/wireless/ath/ath11k/testmode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath11k/testmode.c > b/drivers/net/wireless/ath/ath11k/testmode.c > index > 9be1cd742339c95ffa74c09bee924f4eff15134a..a9751ea2a0b73009bfb600 > d51c3978200ce99114 100644 > --- a/drivers/net/wireless/ath/ath11k/testmode.c > +++ b/drivers/net/wireless/ath/ath11k/testmode.c > @@ -107,7 +107,7 @@ static int ath11k_tm_process_event(struct > ath11k_base *ab, u32 cmd_id, > u32 pdev_id; > > ath11k_dbg(ab, ATH11K_DBG_TESTMODE, > - "event wmi cmd_id %d ftm event msg %pK datalen %d\n", > + "event wmi cmd_id %d ftm event msg %p datalen %d\n", > cmd_id, ftm_msg, length); > ath11k_dbg_dump(ab, ATH11K_DBG_TESTMODE, NULL, "", ftm_msg, > length); > pdev_id = DP_HW2SW_MACID(ftm_msg->seg_hdr.pdev_id); > > -- > 2.49.0