Search Linux Wireless

Re: [PATCH RESEND] brcmfmac: Add an error log for brcmf_sdiod_ramrw()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/14/2025 9:42 AM, Wentao Liang wrote:
The function brcmf_sdio_buscore_activate() calls the function
brcmf_sdiod_ramrw(), but does not check its return value. Log
the error message to prevent silent failure if the function fails.

If the reset vector can not be written to device memory the firmware will not start and we get a probe failure. While it seems useful to log the error I suspect that the MMC/SDIO subsystem will also provide some feedback when we can not access the memory on the device (SDIO CMD52 failure). Oh, well.

Acked-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>
Signed-off-by: Wentao Liang <vulab@xxxxxxxxxxx>
---
  drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux