Search Linux Wireless

Re: [PATCH v4 03/13] media: pci: cx18-av-vbi: Replace open-coded parity calculation with parity_odd()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, "Kuan-Wei Chiu" <visitorckw@xxxxxxxxx>, <tglx@xxxxxxxxxxxxx>, <mingo@xxxxxxxxxx>, <bp@xxxxxxxxx>, <dave.hansen@xxxxxxxxxxxxxxx>, <x86@xxxxxxxxxx>, <jk@xxxxxxxxxx>, <joel@xxxxxxxxx>, <eajames@xxxxxxxxxxxxx>, <andrzej.hajda@xxxxxxxxx>, <neil.armstrong@xxxxxxxxxx>, <rfoss@xxxxxxxxxx>, <maarten.lankhorst@xxxxxxxxxxxxxxx>, <mripard@xxxxxxxxxx>, <tzimmermann@xxxxxxx>, <airlied@xxxxxxxxx>, <simona@xxxxxxxx>, <dmitry.torokhov@xxxxxxxxx>, <mchehab@xxxxxxxxxx>, <awalls@xxxxxxxxxxxxxxxx>, <hverkuil@xxxxxxxxx>, <miquel.raynal@xxxxxxxxxxx>, <richard@xxxxxx>, <vigneshr@xxxxxx>, <louis.peens@xxxxxxxxxxxx>, <andrew+netdev@xxxxxxx>, <davem@xxxxxxxxxxxxx>, <edumazet@xxxxxxxxxx>, <pabeni@xxxxxxxxxx>, <parthiban.veerasooran@xxxxxxxxxxxxx>, <gregkh@xxxxxxxxxxxxxxxxxxx>, <jirislaby@xxxxxxxxxx>, <yury.norov@xxxxxxxxx>, <akpm@xxxxxxxxxxxxxxxxxxxx>, <jdelvare@xxxxxxxx>, <linux@xxxxxxxxxxxx>, <alexandre.belloni@xxxxxxxxxxx>, <pgaj@xxxxxxxxxxx>
Subject: Re: [PATCH v4 03/13] media: pci: cx18-av-vbi: Replace open-coded parity calculation with parity_odd()
From: Arend Van Spriel <arend.vanspriel@xxxxxxxxxxxx>
Date: Thu, 10 Apr 2025 07:08:58 +0200
Cc: <hpa@xxxxxxxxx>, <alistair@xxxxxxxxxxxx>, <linux@xxxxxxxxxxxxxxxxxx>, <Laurent.pinchart@xxxxxxxxxxxxxxxx>, <jonas@xxxxxxxxx>, <jernej.skrabec@xxxxxxxxx>, <kuba@xxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <linux-fsi@xxxxxxxxxxxxxxxx>, <dri-devel@xxxxxxxxxxxxxxxxxxxxx>, <linux-input@xxxxxxxxxxxxxxx>, <linux-media@xxxxxxxxxxxxxxx>, <linux-mtd@xxxxxxxxxxxxxxxxxxx>, <oss-drivers@xxxxxxxxxxxx>, <netdev@xxxxxxxxxxxxxxx>, <linux-wireless@xxxxxxxxxxxxxxx>, <brcm80211@xxxxxxxxxxxxxxx>, <brcm80211-dev-list.pdl@xxxxxxxxxxxx>, <linux-serial@xxxxxxxxxxxxxxx>, <bpf@xxxxxxxxxxxxxxx>, <jserv@xxxxxxxxxxxxxxxx>, <Frank.Li@xxxxxxx>, <linux-hwmon@xxxxxxxxxxxxxxx>, <linux-i3c@xxxxxxxxxxxxxxxxxxx>, <david.laight.linux@xxxxxxxxx>, <andrew.cooper3@xxxxxxxxxx>, "Yu-Chun Lin" <eleanor15x@xxxxxxxxx>
In-reply-to: <740c7de894d39249665c6333aa3175762cfb13c6.camel@sipsolutions.net>
References: <20250409154356.423512-1-visitorckw@gmail.com> <20250409154356.423512-4-visitorckw@gmail.com> <25b7888d-f704-493b-a2d7-c5e8fff9cfb4@broadcom.com> <740c7de894d39249665c6333aa3175762cfb13c6.camel@sipsolutions.net>
User-agent: AquaMail/1.54.1 (build: 105401536)

On April 10, 2025 12:06:52 AM Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:

On Wed, 2025-04-09 at 20:43 +0200, Arend van Spriel wrote:


This is orthogonal to the change to parity_odd() though. More specific
to the new parity_odd() you can now do following as parity_odd()
argument is u64:

err = !parity_odd(*(u16 *)p);


Can it though? Need to be careful with alignment with that, I'd think.


My bad. You are absolutely right.

Gr. AvS

Follow-Ups:
- Re: [PATCH v4 03/13] media: pci: cx18-av-vbi: Replace open-coded parity calculation with parity_odd()
  - From: Kuan-Wei Chiu

References:
- [PATCH v4 00/13] Introduce parity_odd() and refactor redundant parity code
  - From: Kuan-Wei Chiu
- [PATCH v4 03/13] media: pci: cx18-av-vbi: Replace open-coded parity calculation with parity_odd()
  - From: Kuan-Wei Chiu
- Re: [PATCH v4 03/13] media: pci: cx18-av-vbi: Replace open-coded parity calculation with parity_odd()
  - From: Arend van Spriel
- Re: [PATCH v4 03/13] media: pci: cx18-av-vbi: Replace open-coded parity calculation with parity_odd()
  - From: Johannes Berg

Prev by Date: RE: [RFC -v2] wifi: rtw88: sdio: Tx status for management frames
Next by Date: Re: [RFC -v2] wifi: rtw88: sdio: Tx status for management frames
Previous by thread: Re: [PATCH v4 03/13] media: pci: cx18-av-vbi: Replace open-coded parity calculation with parity_odd()
Next by thread: Re: [PATCH v4 03/13] media: pci: cx18-av-vbi: Replace open-coded parity calculation with parity_odd()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Host AP] [ATH6KL] [Linux Wireless Personal Area Network] [Linux Bluetooth] [Wireless Regulations] [Linux Netdev] [Kernel Newbies] [Linux Kernel] [IDE] [Git] [Netfilter] [Bugtraq] [Yosemite Hiking] [MIPS Linux] [ARM Linux] [Linux RAID]