Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> wrote:
>
> Hi Ping-Ke,
>
> On Mon, Apr 7, 2025 at 5:30 AM Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote:
> >
> > Hi Martin,
> >
> > I replied original mail, because I think discussion would be clearer.
> makes sense, thank you!
>
> [...]
> > > @@ -1195,7 +1195,7 @@ static void rtw_sdio_indicate_tx_status(struct rtw_dev *rtwdev,
> > > skb_pull(skb, rtwdev->chip->tx_pkt_desc_sz);
> > >
> > > /* enqueue to wait for tx report */
> > > - if (info->flags & IEEE80211_TX_CTL_REQ_TX_STATUS) {
> > > + if (info->flags & IEEE80211_TX_CTL_REQ_TX_STATUS && queue <= RTW_TX_QUEUE_VO) {
> >
> > Is this because you have seen "failed to get tx report"?
> > Have you tried to increasing RTW_TX_PROBE_TIMEOUT?
> >
> > If it still can't get TX report, we might take this workaround with comments
> > to mention why we need it. Or a local variable with proper naming to point out
> > this, like
> >
> > bool queue_has_no_tx_report = queue > RTW_TX_QUEUE_VO;
> >
> >
> > By the way, USB behavior is very like to SDIO, but TX report seems to work well.
> On my RTL8822CS I can confirm your thought:
> I don't notice any extra "failed to get tx report" messages regardless
> of whether I have "&& queue <= RTW_TX_QUEUE_VO" or not.
>
This workaround might need an chip attribute to enable then.
Not sure if people in the GitHub thread have experiments on all
supported SDIO WiFi chips.
