Search Linux Wireless

Re: [PATCH v2] wifi: wl1251: fix memory leak in wl1251_tx_work

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Abdun Nihaal <abdun.nihaal@xxxxxxxxx>, linux-wireless@xxxxxxxxxxxxxxx, Kalle Valo <kvalo@xxxxxxxxxx>, Michael Nemanov <michael.nemanov@xxxxxx>
Subject: Re: [PATCH v2] wifi: wl1251: fix memory leak in wl1251_tx_work
From: Markus Elfring <Markus.Elfring@xxxxxx>
Date: Mon, 31 Mar 2025 12:42:07 +0200
Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>, "John W. Linville" <linville@xxxxxxxxxxxxx>
In-reply-to: <20250330104532.44935-1-abdun.nihaal@gmail.com>
References: <20250330104532.44935-1-abdun.nihaal@gmail.com>
Ui-outboundreport: notjunk:1;M01:P0:UEwMep2gVxQ=;1y4Va+sjGwAqmdY3Qdw1bdlnq7v 4N/EbXaiHSmsOuiAGLrLQkKaMdFm/dcRrRuS93pBNj9FYIXUTEoPk+3tp0Hw2wBQzhpeXQv9x nnlR8q/kupqJazZ8CPVdltOHO6fEXK846oyCua7qrx+zaQ+aslpkVaUxSPU7vfU9wJoz7UBsl Oj1rcIOH8xIcAYmrkwGLH/2tgsQe4SfUuonKDyMC7Fdxl+1BVfaEuFHyLEazbUGo/f2/TV60e 6+nU7DuB2KmRK0xeZu/zK4sKYRj06STkZdIuOh0VyqwXxj3eFojE5siHIkFD6Kh90LsM9b73J 3+cgRvuUjvBwC5vBfKxVQ4sBqoPKjj+sBWJEk+ib0aqINvQj3/GWyVLsRaCrjsAxRGlwwL2DL UPJUzQoQnJZ7rl3tFYA4kjfDp+7KV3XbRNZYCUdFBUl2sqwKjrwDYNrfLb2M8iYlFAL6pK2B9 UncgiZzxb4k9n2SEzG4HT2+ylSPArUXgTlYR4sJiFITAxn0xbIWLtjO+u5ppCjJbS0IvAnWrl Bgo491kwwoJnyEBrQZQPkQqO0os0Bmacsf3Iy/e6zigFfuGXdCrBsL6GeC3NFy4rbvlRMb/gm t8YLHkSyJlWOy6PkGQqTTQ3rMAsMcUTkyMr1a5JMhv7nTwxWiAOp5yTvQ2MEw2F6D/pG0bhCF NvKpSJ+FCDUvWruzMWWC3taQdExpPD0HEYzC7sXhsAwaxY/dKz8Kf8g2krdkvbxg0d3kVWhhX jJ/orOpaZLbFD8ZLzz+W9MrrE4/oiVjX8WLBEZmnj5eZB8tVdBYqDF5Vqu9Sx9FHoWk1FNE6w n1viIEKEDd9bwqRUXOQH81z6IIdCBHwdGQg+JLQq8H1i/O2dusAL9ge6cGghTiefe4n3qLyDF 2UiEZz1bly1oXr4ZZwD4iKX/0axzBxGwZUeqaCCAG2+Tq+E7Pbh3x56mWlgOZpOmf4+36oaFG MJqVgyc/dU+da2Q/0xX3yHRjF8gZUp72M0pUgSUIgD4AqQuPCzSoUU3s42k5AYd3DXf3xYNgY uoR/TGc66ITvB3N74YJwO9kvG2bKCZwW+xRV/NHmTR72uGrtyzEhCdYOZLP3Zjnt977bYW4uW CpAJyJiUm/JSQ1DjQ7S/Afir2nMDR1eeDJljq942PdJl2o3g9sGFQG4p0OVtaI1L2Q6XM1AWN bKkb/A1uAIRnRY9n3H0LpW8ez4cRth/LFaAy51lfFH/t0GdtGpDkqA9s5PLs8beDNL/3VuftC /5Qj6wFWDPqzdwP7cVwxfpwYQpLA2zHIwk0mtTt3d7kiJA87prJl7U8J/wtEeknBlCRUml6L9 VEaI6rNtzfDkzoi69ylZjMeTS4cwJnbgwxX3tRGqdwZjqPuJM4j4rnjW0O4eILbHxhB/31xsP qKONIEvGvYEAlxECbelfL3BOJpL43xFEDMlIxddWZ9x8EQuVUx/s3et22BZ11AY/60FWRuY4E MgvDCgKBHWx5wmVYCGv05Rr32/uc6c7U8HIkiJsnwPUqTfMS5
User-agent: Mozilla Thunderbird

> The skb dequeued from tx_queue is lost when wl1251_ps_elp_wakeup fails

                                                                   failed?


> with a -ETIMEDOUT error. Fix that by queueing the skb back to tx_queue.

Can an other summary phrase be more appropriate for such a software situation?

Regards,
Markus

Follow-Ups:
- Re: [PATCH v2] wifi: wl1251: fix memory leak in wl1251_tx_work
  - From: Johannes Berg

References:
- [PATCH v2] wifi: wl1251: fix memory leak in wl1251_tx_work
  - From: Abdun Nihaal

Prev by Date: [PATCH] wifi: mt76: mt7996: Add NULL check in mt7996_thermal_init
Next by Date: Re: [PATCH v2] wifi: wl1251: fix memory leak in wl1251_tx_work
Previous by thread: Re: [PATCH v2] wifi: wl1251: fix memory leak in wl1251_tx_work
Next by thread: Re: [PATCH v2] wifi: wl1251: fix memory leak in wl1251_tx_work
Index(es):
- Date
- Thread

[Index of Archives] [Linux Host AP] [ATH6KL] [Linux Wireless Personal Area Network] [Linux Bluetooth] [Wireless Regulations] [Linux Netdev] [Kernel Newbies] [Linux Kernel] [IDE] [Git] [Netfilter] [Bugtraq] [Yosemite Hiking] [MIPS Linux] [ARM Linux] [Linux RAID]