Hi all, this patchset introduces support for Nordic Semiconductor nRF70 series of wireless companion IC. Nordic nRF70 series are FullMAC devices, which communicate over SPI or QSPI interface. This driver provides support for STA, AP and monitor modes, in combination with up to 2 VIFs. Throughput of up to ~16 Mbit/s has been observed while using QSPI. Patch [1/2] adds the nRF70 driver. Patch [2/2] provides related Devicetree bindings documentation. As this is our first Linux WLAN driver, I am tagging this as RFC and looking for any sort of feedback, before I turn it into a regular submission. In the meantime, here are some pending questions that I have: 1) Nordic gave us permission to upstream the firmware blob [1] required to use this driver. As that needs to go through separate linux-firmware repository and is subject to different licensing, should I try to upstream it in parallel with this series, or does it need to wait until the kernel driver gets in? 2) In AP mode, for each connected peer I maintain a pending queue for TX skbs that can't be transmitted while the peer is in power save mode. I then use a wiphy_work (nrf70_pending_worker) to move the collected skbs into a single hw queue once the peer is able to receive again. This means there can be multiple workers putting skbs onto the hw queue at any given time. As this scheme relies on the wiphy_work workqueue, can I assume that multiple workers will be able to run in parallel, even on a system with a single CPU? If not, what would be a better solution to the above problem? 3) nRF70 hardware communicates using byte packed, little-endian payloads (documented in nrf70_cmds.h). As these can get very large and complicated, I decided against writing some sort of endianess conversion scheme, and simply dropped big endian support by this driver. Is that acceptable? 4) Please put particular attention to the wiphy configuration. I am not 100% confident I got all the flags/features/band caps right. PS. checkpatch.pl spits out what I believe to be a false positive: > ERROR: Macros with complex values should be enclosed in parentheses > #5914: FILE: drivers/net/wireless/nordic/nrf70_rf_params.h:85: > +#define NRF70_PHY_PARAMS \ The above define is used for generating the nrf7002_qfn_rf_params array, and as such cannot be enclosed in parentheses. Cheers, Artur [1] https://github.com/nrfconnect/sdk-nrfxlib/raw/refs/heads/main/nrf_wifi/bin/ncs/default/nrf70.bin Artur Rojek (2): net: wireless: Add Nordic nRF70 series Wi-Fi driver dt-bindings: wireless: Document Nordic nRF70 bindings .../bindings/net/wireless/nordic,nrf70.yaml | 56 + drivers/net/wireless/Kconfig | 1 + drivers/net/wireless/Makefile | 1 + drivers/net/wireless/nordic/Kconfig | 26 + drivers/net/wireless/nordic/Makefile | 3 + drivers/net/wireless/nordic/nrf70.c | 4671 +++++++++++++++++ drivers/net/wireless/nordic/nrf70_cmds.h | 1051 ++++ drivers/net/wireless/nordic/nrf70_rf_params.h | 98 + 8 files changed, 5907 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/wireless/nordic,nrf70.yaml create mode 100644 drivers/net/wireless/nordic/Kconfig create mode 100644 drivers/net/wireless/nordic/Makefile create mode 100644 drivers/net/wireless/nordic/nrf70.c create mode 100644 drivers/net/wireless/nordic/nrf70_cmds.h create mode 100644 drivers/net/wireless/nordic/nrf70_rf_params.h -- 2.49.0
