Search Linux Wireless

Re: wifi: mt76: mt7996: avoid potential null deref in mt7996_get_et_stats()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>, Qasim Ijaz <qasdev00@xxxxxxxxx>, linux-wireless@xxxxxxxxxxxxxxx, linux-mediatek@xxxxxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
Subject: Re: wifi: mt76: mt7996: avoid potential null deref in mt7996_get_et_stats()
From: Markus Elfring <Markus.Elfring@xxxxxx>
Date: Mon, 24 Mar 2025 08:33:39 +0100
Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>, Angelo Gioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>, Bo Jiao <bo.jiao@xxxxxxxxxxxx>, Felix Fietkau <nbd@xxxxxxxx>, James Dutton <james.dutton@xxxxxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, Jonas Gorski <jonas.gorski@xxxxxxxxx>, Lorenzo Bianconi <lorenzo@xxxxxxxxxx>, Matthias Brugger <matthias.bgg@xxxxxxxxx>, Peter Chiu <chui-hao.chiu@xxxxxxxxxxxx>, Ryder Lee <ryder.lee@xxxxxxxxxxxx>, Sean Wang <sean.wang@xxxxxxxxxxxx>, Shayne Chen <shayne.chen@xxxxxxxxxxxx>
In-reply-to: <223c7280-443d-49b4-96b2-90472339dcd4@stanley.mountain>
References: <20250322141910.4461-1-qasdev00@gmail.com> <d1df5d97-4691-40d4-a6cc-416505f35164@web.de> <92d1a410788c54facedec033474046dda6a1a2cc.camel@sipsolutions.net> <CAAMvbhGrJ9b3Aab9+2a5zmvEgf0GZFmHLCC7Hud+egUE28voHQ@mail.gmail.com> <223c7280-443d-49b4-96b2-90472339dcd4@stanley.mountain>
Ui-outboundreport: notjunk:1;M01:P0:jO20oZj/TDE=;aGj7rYdAkRcQW7DeTxELt09CwZj IMJ4QmMwA/3OFvwsgsx+W+vN98ShDLwI66ERueilwHOK24GN90dOcZ2A1m+MUdhx2kH9EtOb8 GpBM4wwOWefzfn5U56aJhfP1E3DwV6ungO7Vvh74LZqMJE6bGTdHJMTx6R4zKOtsb4INcAHwM poYPqYUg5HK0TM6npx137BrPjtnruqBeRO2GQsLqZ8FTj724duSrnDT3//T6S7aMztQUaFx6J SkDU9SXpaIdDOp6/YoaNw8JrB1RpTKSxNIpLOrF5wOCnormOMXjAmMM5e+vSmJ0M02DS7F1cl DYw5vfl/PBhGELoXNFOrMyp5oFu1x+O5E51HA22nRsGOXftFcaEWTSzdxsVEePdyG+QTWEjAJ wMPXa7wmzCXtohStcMSk3uRk/QbwW/PW2X6bUniVdn8oAcFwVQ+0YFGYyzEog9tasB1pHsWtw TYAZFhNFHl+u+CzIFI2/ozAYEtATj/tCrR0g7XUTxT6TSqB2Vdb9TjvcE+gGayNWtdXm/yM5U e1cCx7Q+Y2syqylyrykPExIaqEnzrFA8Lmq+eReqbjcav6EsWZUOvdSF7kwCaBefwGBvcf22f ROchFCHsXAhpSK9gBgrAzVxoQl4qblOrpsOENuTWx9jcHsDvv5w2vHkvW4GdpzGRPRKiq5l8j KbWP+xgKx1HV8FpskDsEAb7/1foieNAjOwCLRZJ7SGcoTeaVczjWxg3cTG+YulML9AmTgHBA0 zffaTDuiMvucBG2SAj/2LloeSBPIMg0xQtjHwTWkEqGcppQN8hOYzNXKcGpJiVszgB3wnjW+0 wIczXjNR4Z8Paj5H+g537DdGuw8lrAGoQNfWK1ScAauE2IYtJPyO+mFtEzQkmYNnyVk/ompDb 3PnMdlmAKZpPuzRbfCT+I+Z7ty9PEExDxvkJ6b3epvlbzLVtnYfPH+XSWwXIHGP+7HEehn4/s Rimek8h2ei3UvTqbuJK1crjfaXpN9urR0vFRJSANz0uTwLnUxicEX+vZ9RNl0TTikF2jzECix a1JaA88odXlJOG/WCeqZXv6AXYa6kwUXwQkBUnz22/J5H6+p9tqWcrhfA9WdtVDg+BCeV9niA /bRV8bytHFiTFBvTfULpmLU8HPC+bInE8AXFA5FI4r9FYSLQxHO+HKGSeTdSbL+h4lL78WAfc rIIjTih9nMGSlskR2OXtFxGnuIC6pOnrvPWespFIh47fwCDCzXv7v9Mo2aT6IA5NWAgtbL3Zg fWofTQ/7m+MeZu9VGM1GPm2mrWkMZnuGhTOdIcweduPdrWKQ6aR/zKIdha8QxSumnsIcXC9Ro lKvoiXS2En6XgEWktqn+GL5Q5O9Kfj1eZKVeHoKG3V769mQmQFGUXtJchtPR9FZL1FCyjwDS9 L8/za+xtLeL4VD37A+P28rCywVzjlh5f7uhpm9p5HX05l1OMqNr+Hck7WhI+ww7k+NBvhXglG lbaKo5Cuq4xGEPQlwWhoMX2SpxUnXuT/h4kczqgy9ikO/HlEg
User-agent: Mozilla Thunderbird

> Also the "phy" point will never be NULL so the check should be removed.
How many tools can help to determine such a software aspect with inter-procedural analyses?

Regards,
Markus

Follow-Ups:
- Re: wifi: mt76: mt7996: avoid potential null deref in mt7996_get_et_stats()
  - From: Dan Carpenter

References:
- [PATCH] wifi: mt76: mt7996: avoid potential null deref in mt7996_get_et_stats()
  - From: Qasim Ijaz
- Re: [PATCH] wifi: mt76: mt7996: avoid potential null deref in mt7996_get_et_stats()
  - From: Markus Elfring
- Re: [PATCH] wifi: mt76: mt7996: avoid potential null deref in mt7996_get_et_stats()
  - From: Johannes Berg
- Re: [PATCH] wifi: mt76: mt7996: avoid potential null deref in mt7996_get_et_stats()
  - From: James Dutton
- Re: [PATCH] wifi: mt76: mt7996: avoid potential null deref in mt7996_get_et_stats()
  - From: Dan Carpenter

Prev by Date: Re: [PATCH v11 10/10] wifi: ath12k: add monitor interface support on QCN9274
Next by Date: Re: wifi: mt76: mt7996: avoid potential null deref in mt7996_get_et_stats()
Previous by thread: Re: [PATCH] wifi: mt76: mt7996: avoid potential null deref in mt7996_get_et_stats()
Next by thread: Re: wifi: mt76: mt7996: avoid potential null deref in mt7996_get_et_stats()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Host AP] [ATH6KL] [Linux Wireless Personal Area Network] [Linux Bluetooth] [Wireless Regulations] [Linux Netdev] [Kernel Newbies] [Linux Kernel] [IDE] [Git] [Netfilter] [Bugtraq] [Yosemite Hiking] [MIPS Linux] [ARM Linux] [Linux RAID]