…
> or link_sta_dereference_protected() fail the code jumps to
> the error_unlink label and returns ret which is uninitialised.
…
* Would you like to avoid typos in such a change description?
* Can any background information become more relevant for the usage of
source code analysis tools?
* Can the summary phrase be improved also another bit?
…
> +++ b/drivers/net/wireless/mediatek/mt76/mt7996/main.c
> @@ -998,16 +998,22 @@ mt7996_mac_sta_add_links(struct mt7996_dev *dev, struct ieee80211_vif *vif,
> continue;
>
> link_conf = link_conf_dereference_protected(vif, link_id);
> - if (!link_conf)
> + if (!link_conf) {
> + err = -EINVAL;
> goto error_unlink;
> + }
>
> link = mt7996_vif_link(dev, vif, link_id);
> - if (!link)
> + if (!link) {
> + err = -EINVAL;
> goto error_unlink;
> + }
…
Can software development interests evolve in ways which might make the avoidance
of duplicate source code more feasible also for affected error/exception handling?
Regards,
Markus
