On 1/15/25 18:29, Dmitry Baryshkov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Wed, Jan 15, 2025 at 09:19:45PM +0000, Ajay.Kathat@xxxxxxxxxxxxx wrote: >> On 1/15/25 12:02, Marek Vasut wrote: >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know >>> the content is safe >>> >>> On 1/15/25 6:18 PM, Ajay.Kathat@xxxxxxxxxxxxx wrote: >>>> This commit adds WLAN firmware for wilc3000 which is supported in >>>> mainline >>>> Linux with commit [1]. >>>> >>>> FW version: 16.1.2 >>> https://github.com/linux4wilc/firmware.git >>> >>> containers firmware v16.3 , why add this old firmware v16.1 here ? >> >> wilc1000 and wilc3000 follow the same version numbering. Since, wilc3000 >> firmware is getting added for the first time, I thought to include the >> corresponding wilc3000 firmware version,which is v16.1.2, in this commit. > > Please use separate Version: fields for all the firmware rather than > havign misleading and incorrect specification. > > While we are at it, do the old ap/p2p/normal firmware also have 16.0 > version? If not, the Version clause is incorrect anyway (there should be > an empty line before the unified firmware entry). > Granted that support for non-unified firmware has been dropped in 2016, > maybe it's time to drop these files from linux-firmware too? Yes, the non-unified firmware was quite old approach and it got replaced with unified firmware. The different mode specific firmware(ap/p2p/sta) files can be dropped now. I will send a separate patch to remove them. > >> Going forward, both these firmware will be upgraded with a single patch. >> Once this patch is applied, I will submit a patch to upgrade both >> wilc1000 and wilc3000 firmware to v16.3. > > Just my 2c, but I don't think that this patch should be applied in its > current form. > I noticed that the patch is already applied so I will send a new patch by including individual version for each firmware and group firmware files that come under same version. For WILC 16.3 firmware upgrade, I'm planning to structure the firmware information like below. Any suggestion? ------- Driver: wilc1000 - Atmel 802.11n WLAN driver for WILC1000 & WILC3000 File: atmel/wilc1000_wifi_firmware.bin Version: 14.04 File: atmel/wilc1000_wifi_firmware-1.bin File: atmel/wilc3000_wifi_firmware-1.bin Version: 16.3 ------- Regards, Ajay
