Re: [PATCH] mm/numa: Rename memory_add_physaddr_to_nid to memory_get_phys_to_nid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: pratyush.brahma@xxxxxxxxxxxxxxxx, Madhavan Srinivasan <maddy@xxxxxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, Christophe Leroy <christophe.leroy@xxxxxxxxxx>, Heiko Carstens <hca@xxxxxxxxxxxxx>, Vasily Gorbik <gor@xxxxxxxxxxxxx>, Alexander Gordeev <agordeev@xxxxxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>, Sven Schnelle <svens@xxxxxxxxxxxxx>, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, Len Brown <lenb@xxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Vishal Verma <vishal.l.verma@xxxxxxxxx>, Dave Jiang <dave.jiang@xxxxxxxxx>, Ira Weiny <ira.weiny@xxxxxxxxx>, Oscar Salvador <osalvador@xxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Danilo Krummrich <dakr@xxxxxxxxxx>, Davidlohr Bueso <dave@xxxxxxxxxxxx>, Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>, Alison Schofield <alison.schofield@xxxxxxxxx>, "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx>, Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>, Wei Liu <wei.liu@xxxxxxxxxx>, Dexuan Cui <decui@xxxxxxxxxxxxx>, Pankaj Gupta <pankaj.gupta.linux@xxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Xuan Zhuo <xuanzhuo@xxxxxxxxxxxxxxxxx>, Eugenio Pérez <eperezma@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Mike Rapoport <rppt@xxxxxxxxxx>
Subject: Re: [PATCH] mm/numa: Rename memory_add_physaddr_to_nid to memory_get_phys_to_nid
From: David Hildenbrand <david@xxxxxxxxxx>
Date: Mon, 18 Aug 2025 08:58:59 +0200
Cc: linuxppc-dev@xxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx, nvdimm@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-cxl@xxxxxxxxxxxxxxx, linux-hyperv@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
In-reply-to: <20250818-numa_memblks-v1-1-9eb29ade560a@oss.qualcomm.com>
References: <20250818-numa_memblks-v1-1-9eb29ade560a@oss.qualcomm.com>
User-agent: Mozilla Thunderbird

On 18.08.25 08:41, pratyush.brahma@xxxxxxxxxxxxxxxx wrote:

From: Pratyush Brahma <pratyush.brahma@xxxxxxxxxxxxxxxx>

The function `memory_add_physaddr_to_nid` seems a misnomer.
It does not to "add" a physical address to a NID mapping,
but rather it gets the NID associated with a given physical address.

You probably misunderstood what the function is used for: memory hotplugaka "memory_add".


This patch is making matters worse by stripping that detail, unfortunately.


--
Cheers

David / dhildenb

Follow-Ups:
- Re: [PATCH] mm/numa: Rename memory_add_physaddr_to_nid to memory_get_phys_to_nid
  - From: Pratyush Brahma

References:
- [PATCH] mm/numa: Rename memory_add_physaddr_to_nid to memory_get_phys_to_nid
  - From: pratyush . brahma

Prev by Date: [PATCH v3] virtio-vdpa: Drop redundant conversion to bool
Next by Date: [PATCH] virtio-vdpa: simplify the code by removing unnecessary variables
Previous by thread: [PATCH] mm/numa: Rename memory_add_physaddr_to_nid to memory_get_phys_to_nid
Next by thread: Re: [PATCH] mm/numa: Rename memory_add_physaddr_to_nid to memory_get_phys_to_nid
Index(es):
- Date
- Thread

[Index of Archives] [KVM Development] [Libvirt Development] [Libvirt Users] [CentOS Virtualization] [Netdev] [Ethernet Bridging] [Linux Wireless] [Kernel Newbies] [Security] [Linux for Hams] [Netfilter] [Bugtraq] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux RAID] [Linux Admin] [Samba]